Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Considering replace the benchmark result rather than append to the comment. #1094

Closed
IWANABETHATGUY opened this issue May 11, 2024 · 1 comment · Fixed by #1220
Closed

Considering replace the benchmark result rather than append to the comment. #1094

IWANABETHATGUY opened this issue May 11, 2024 · 1 comment · Fixed by #1220

Comments

@IWANABETHATGUY
Copy link
Contributor

It looks like we always try to put the benchmark of the last comment into the benchmark comments, this may cause the benchmark comments very long when you push too many commits to a pull request

@hyf0
Copy link
Member

hyf0 commented May 11, 2024

Agreed. I choose the replace strategy in action but it doesn't seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants