Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Should we create a new public fork for this repository? #144

Open
latobibor opened this issue Apr 26, 2023 · 8 comments
Open

Should we create a new public fork for this repository? #144

latobibor opened this issue Apr 26, 2023 · 8 comments

Comments

@latobibor
Copy link

It seems that the PRs even though they are getting approved sometimes are not getting merged for 1 year by now. The last one was merged 1st of April 2022. A ton has changed under the hood in react-native that breaks builds and having important features like barcode scanning blocking upgrades indefinitely is just not feasible.

If there is already a public fork of this, please let me know, or if there is an alternative. Otherwise someone not in a time-crunch please, please fork this repo, merge those PRs and let's get on with it.

@JoaoSoaresDev
Copy link

Any updates on this? Haven't found any forks of this repo anywhere.

@har0ld-scl
Copy link

har0ld-scl commented Aug 7, 2023

Same problem here, it seems that this repo is already dead. I've waiting for this PR127 to be merged for several weeks.

I'm afraid that this dependency could block my project to upgrade to newer versions of React Native (0.72 and above).

@latobibor
Copy link
Author

@JoaoSoaresDev and @har0ld-scl
It seems that react-native-vision-camera is going to ship with QR code reader. However, it's not a priority as yet. I asked if there's any combination in which I can have a working camera with a QR code reader for RN versions 0.70+ and @metrix_hu was kind enough to share their method:

mrousavy/react-native-vision-camera#1662 (comment)

@DeveloperMCD
Copy link

DeveloperMCD commented Aug 17, 2023

I am looking for the same thing -- I want the latest React Native, but I need CROSS-PLATFORM barcode scanning which forces me to use React Native Vision Camera. There's a great barcode scanning library for Android-only, which I had working in my app just fine. But that's not good enough; I need iOS too.

There are only (2) "Frameprocessor" plugins for doing barcode scanning with RNVC. One of them is proprietary/commercial, and so expensive the price is "Call for a quote". And then there's this one! So not a lot of choices there.
https://www.react-native-vision-camera.com/docs/guides/frame-processor-plugin-list

This man has supposedly forked and updated this repo to work with "RNVC v3" circa April 2023. I assume the chances to RNVC since April are minor, so that's a good bit of progress.
https://github.com/rkmackinnon/vision-camera-code-scanner/tree/react-native-vision-camera-v3

@maxinminax
Copy link

I have tried and it's work on version rc.3 but in last rc.5, it have errors in the swift file when build

@DeveloperMCD
Copy link

"I have tried and it works on version rc.3 but in last rc.5, it has errors in the swift file during build."

Is it possible to get those errors fixed?

@DeveloperMCD
Copy link

For what it's worth, I tried the mackinnon fork (which I forked to my own repo, but I digress) on 3.0.0-rc5, and it doesn't build successfully on Android either.

/home/matthew/dev/stackbayapp/node_modules/vision-camera-v3-barcode-scanner/android/src/main/java/com/visioncameracodescanner/VisionCameraCodeScannerPlugin.java:40: error: VisionCameraCodeScannerPlugin is not abstract and does not override abstract method callback(Frame,ReadableNativeMap) in FrameProcessorPlugin
public class VisionCameraCodeScannerPlugin extends FrameProcessorPlugin {
^
/home/matthew/dev/stackbayapp/node_modules/vision-camera-v3-barcode-scanner/android/src/main/java/com/visioncameracodescanner/VisionCameraCodeScannerPlugin.java:62: error: method does not override or implement a method from a supertype
@OverRide
^
/home/matthew/dev/stackbayapp/node_modules/vision-camera-v3-barcode-scanner/android/src/main/java/com/visioncameracodescanner/VisionCameraCodeScannerPlugin.java:251: error: constructor FrameProcessorPlugin in class FrameProcessorPlugin cannot be applied to given types;
super("scanCodes");
^
required: no arguments
found: String
reason: actual and formal argument lists differ in length
/home/matthew/dev/stackbayapp/node_modules/vision-camera-v3-barcode-scanner/android/src/main/java/com/visioncameracodescanner/VisionCameraCodeScannerPluginPackage.java:19: error: cannot find symbol
FrameProcessorPlugin.register(new VisionCameraCodeScannerPlugin());
^
symbol: method register(VisionCameraCodeScannerPlugin)
location: class FrameProcessorPlugin
4 errors

FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':vision-camera-v3-barcode-scanner:compileDebugJavaWithJavac'.

Compilation failed; see the compiler error output for details.

@DeveloperMCD
Copy link

By the way, I couldn't get it to work on 3.0.0-rc3 either.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@maxinminax @DeveloperMCD @latobibor @har0ld-scl @JoaoSoaresDev and others