Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The purger is not doing anything. #338

Open
jecaro opened this issue Sep 19, 2024 · 0 comments · May be fixed by #339
Open

The purger is not doing anything. #338

jecaro opened this issue Sep 19, 2024 · 0 comments · May be fixed by #339

Comments

@jecaro
Copy link

jecaro commented Sep 19, 2024

I've seen the purger recommended in different places:

The comments clearly state that you guys at rockset don't use it in prod. Fair enough. But if it is still recommended to use and has an option to turn it on, then it should at least do something.

Right now, it is both broken and not doing anything (see that commented code, also here).

Those TODOs are 7 years old. The option's documentation says that it is true by default but fortunately it is actually false.

For those reasons, I recommend deleting that option along the code because that's just dead code at this point.

@jecaro jecaro linked a pull request Sep 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant