-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Networks should not be hard-coded #438
Comments
FYI: I am going to start investigating this one... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Smartnode should ideally work for any ethereum network.
If we move network-specific constants and behavior into .yml files, we can trivially support locally run testnets, which will be important for e2e test automation. Additionally, chores like #437 become trivial- only one file needs to be updated, with optional "what's changed" update elsewhere.
We can package some 'default' networks with smartnode-install, and read an optional extra-networks.yml from the project directory (~/.rocketpool)
Edit: additionally, putting everything that fornax had to delete in
The text was updated successfully, but these errors were encountered: