Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smartnode should clean up keys from failed deposits #379

Open
jshufro opened this issue Jul 19, 2023 · 0 comments
Open

smartnode should clean up keys from failed deposits #379

jshufro opened this issue Jul 19, 2023 · 0 comments

Comments

@jshufro
Copy link
Contributor

jshufro commented Jul 19, 2023

image

basically, this is a land mine, and while it isn't smartnode's fault, if rocketpool node deposit exits with an error smartnode should delete the derived keys (but not decrement next_account).

This can be easily done with a defer that checks a bool that is only set on success, and if that bool is false, the keys are deleted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jshufro