Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effective stake calculation is wrong for node status and rewards commands #362

Open
torfbolt opened this issue May 11, 2023 · 0 comments
Open

Comments

@torfbolt
Copy link

The current implementation shows an effective stake limit increase for minipools that are not active on the beacon chain yet. This is not in line with the rewards tree calculation spec (https://github.com/rocket-pool/rocketpool-research/blob/master/Merkle%20Rewards%20System/rewards-calculation-spec.md), resulting in wrong reward predictions in case of e.g. pending validators.

Additionally, the current rewards documentation (https://docs.rocketpool.net/guides/node/rewards.html#rpl-rewards) is very unspecific about the effective stake calculation.

In combination, this can lead to node operators making wrong decisions about minipool deposits and exits, based on how these affect the effective stake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant