Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo/Redo #1008

Open
aboodman opened this issue Jul 31, 2022 · 5 comments
Open

Undo/Redo #1008

aboodman opened this issue Jul 31, 2022 · 5 comments
Labels
Future Something we want to fix but is not blocking next release

Comments

@aboodman
Copy link
Contributor

aboodman commented Jul 31, 2022

Undo/redo is a very common feature request in collaborative applications and doing it correctly is somewhat subtle (e.g., see posts by Figma and Liveblocks).

Many Replicache users have created undo/redo on their own without too much trouble but it would be good to provide a solid, tested library analogous to https://github.com/rocicorp/fractional-indexing and other helper libraries we've released.

@arv
Copy link
Contributor

arv commented Oct 20, 2022

What else needs to be done here? Is https://github.com/rocicorp/undo enough to close this?

@cesara

@arv arv added the Future Something we want to fix but is not blocking next release label Oct 20, 2022
@cesara
Copy link

cesara commented Oct 21, 2022

@arv there is a particular scenario that undo is not being handled correctly.

Reference our Redoing undo notion doc for a clearer understanding of the issue.

We can open a new Issue to handle the invariant.

@arv
Copy link
Contributor

arv commented Oct 21, 2022

I see. This is still future work then.

@heymartinadams
Copy link

Can we use this library already in production, or should we hold off until you launch this feature as part of the official Replicache? Undo/redo is a highly requested feature for us.

@aboodman
Copy link
Contributor Author

Here is the notion doc @cesara mentions: https://replicache.notion.site/Redoing-undo-c0183b91d12c4272a3482e3233cc2890?pvs=4.

It describes the edge case which this library doesn't handle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Future Something we want to fix but is not blocking next release
Projects
Status: In Progress
Development

No branches or pull requests

4 participants