Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use random github matrix generation #1460

Open
vlsi opened this issue Jun 6, 2023 · 4 comments
Open

Use random github matrix generation #1460

vlsi opened this issue Jun 6, 2023 · 4 comments
Labels

Comments

@vlsi
Copy link
Collaborator

vlsi commented Jun 6, 2023

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

I suggest using https://github.com/vlsi/github-actions-random-matrix for matrix generation.

It would make it easier to configure the matrix, it would increase test coverage, and it would reduce the amount of CI resources needed (fewer jobs can gain better coverage).

See sample in apache/jmeter#693


*Edit* by @robstoll Note that we currently don't execute exactly the same steps for windows and ubuntu. I think it would be a good point in time to migrate a few steps into jobs and run them in parallel to speed up the whole pipeline a bit. The reason why we have the sequential setup is to compile only once but maybe there is a way to somehow share the outcome of the compilations with further jobs.
@robstoll
Copy link
Owner

robstoll commented Jun 6, 2023

nice idea, I see the benefit of using different jdks. Go ahead 👍

Out of curiosity: is there a way to fix the config so that one can re-run the same config after a fix?

@vlsi
Copy link
Collaborator Author

vlsi commented Jun 6, 2023

Out of curiosity: is there a way to fix the config so that one can re-run the same config after a fix?

Everybody asks it, and I never needed rerunning the same in CI. Random runs in CI are just fine.

The useful feature though is to print a command line to reproduce the run locally (e.g. lang, locale, timezone, other args)

@robstoll
Copy link
Owner

robstoll commented Jun 6, 2023

I guess you have setup all different jdks locally then ? or how do you reproduce it locally?

@vlsi
Copy link
Collaborator Author

vlsi commented Jun 6, 2023

I have several jdks locally since some of the projects require Java 17, and some can't build with 17 :)

The need to reproduce locally comes when you want set a breakpoint. In that case installing a JDK is not a big deal

@robstoll robstoll changed the title Use random github matix generation Use random github matrix generation Jun 8, 2023
@robstoll robstoll added the good first issue Good for newcomers label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants