Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add online previews for pull requests #23

Closed
robmoss opened this issue Sep 16, 2022 · 1 comment · Fixed by #26
Closed

Add online previews for pull requests #23

robmoss opened this issue Sep 16, 2022 · 1 comment · Fixed by #26
Assignees
@robmoss @EamonConway
Labels
enhancement New feature or request

Comments

@robmoss
Copy link
Owner

robmoss commented Sep 16, 2022

We could use the Deploy PR Preview action to publish pull requests to https://robmoss.github.io/git-is-my-lab-book/pr-preview/pr-[number]/, which would be particularly useful for supporting new contributors. I discovered this action via the marp-to-pages workflow.
@robmoss robmoss added the enhancement New feature or request label Sep 16, 2022
@robmoss robmoss mentioned this issue Sep 20, 2022
Closed
@robmoss
Copy link
Owner Author

robmoss commented Sep 20, 2022

We may need to use JamesIves/github-pages-deploy-action@v4 to deploy the master branch. In other repositories I've used peaceiris/actions-gh-pages@v3, but it doesn't preserve the PR previews.

@robmoss robmoss mentioned this issue Sep 21, 2022
Merged
@robmoss robmoss linked a pull request Sep 21, 2022 that will close this issue
Add online previews for pull requests #26
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robmoss robmoss

@EamonConway EamonConway

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add online previews for pull requests robmoss/git-is-my-lab-book
2 participants
@robmoss @EamonConway