Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to transform arguments #4

Open
roblafeve opened this issue Feb 8, 2017 · 3 comments
Open

Add options to transform arguments #4

roblafeve opened this issue Feb 8, 2017 · 3 comments
Assignees
Projects

Comments

@roblafeve
Copy link
Owner

Current signature is (payload) but should optionally be (payload, { meta, error }.

Code needing to be changed:
https://github.com/roblafeve/redux-factory/blob/master/src/helpers.js#L11

@dmdez
Copy link
Collaborator

dmdez commented Feb 10, 2017

@roblafeve what would be in the error options? would it be a type of error? or just a string?

@roblafeve
Copy link
Owner Author

@dmdez good question—basically I think it could be anything. You may look at https://github.com/acdlite/flux-standard-action to see what is valid though.

@dmdez
Copy link
Collaborator

dmdez commented Feb 10, 2017

Also, where would I add a test for this? All tests i see seem to take a FSA, not really a function call with a payload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants