Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable vibration not working on ios #51

Open
larsandremoen opened this issue May 21, 2021 · 3 comments
Open

Disable vibration not working on ios #51

larsandremoen opened this issue May 21, 2021 · 3 comments

Comments

@larsandremoen
Copy link
Contributor

Unable to disable the vibration with vibrate=false.

For me it looks like it's becuase this guard is always true due to prevProps.vibrate always being true.

Modifying the guard to the following seems to be working as intended:
if (this.props.vibrate && this.props.isOpen && !prevProps.isOpen) {...}
@robcalcroft
Copy link
Owner

Hi @7arsandre good spot, happy to take a pull request if you have a fix to hand?

@larsandremoen
Copy link
Contributor Author

@robcalcroft I will do a PR on this! 👌

@larsandremoen
Copy link
Contributor Author

larsandremoen commented Jun 9, 2021 •
edited
Loading

Pushed the PR: #52
@robcalcroft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robcalcroft @larsandremoen