-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AsyncDataloader improvements for Rails #4921
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
AsyncDataloader
could be improved in some ways to support Rails better:isolation_level = :fiber
, if you callconnected_to { ... }
in the surrounding context (parent Fiber), then child Fibers don't respect that -- but they should in this case.I think these are both good defaults and it can be accomplished with a Rails-specific module included as-needed, or something similar.
The text was updated successfully, but these errors were encountered: