Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALG mechanism needs improvements #92

Open
rmind opened this issue May 23, 2020 · 0 comments
Open

ALG mechanism needs improvements #92

rmind opened this issue May 23, 2020 · 0 comments

Comments

@rmind
Copy link
Owner

rmind commented May 23, 2020

  • Race condition when unloading ALG module: npf_nat_freealg() vs lock-free readers.
  • Inspection as a loop in npf_alg_conn() is not particularly efficient. It could be optimized to be: 1) per-protocol 2) only limited to ALGs which perform inspection, rather than all.
  • npf_alg_exec() should only be performed if the NAT entry has an associated ALG; it is currently applicable only for the dynamic NAT anyway. If there will be ALGs operating with the static NAT, then npfa_funcs_t::snat could be added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant