Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull out DateElement component from antd #3352

Open
4 tasks done
nickgros opened this issue Jan 5, 2023 · 1 comment
Open
4 tasks done

Pull out DateElement component from antd #3352

nickgros opened this issue Jan 5, 2023 · 1 comment
Assignees
Labels
bug p1 Important to fix soon

Comments

@nickgros
Copy link
Contributor

nickgros commented Jan 5, 2023

Prerequisites

What theme are you using?

antd

Version

5.x

Current Behavior

Implementation should match chakra and core

Expected Behavior

No response

Steps To Reproduce

No response

Environment

- OS:
- Node:
- npm:

Anything else?

No response

@nickgros nickgros added bug needs triage Initial label given, to be assigned correct labels and assigned labels Jan 5, 2023
@nickgros nickgros self-assigned this Jan 5, 2023
@nickgros nickgros removed the needs triage Initial label given, to be assigned correct labels and assigned label Jan 5, 2023
@heath-freenome
Copy link
Member

heath-freenome commented Jan 15, 2023

@nickgros While you are at it, there seem to be a set of common types and helper functions that maybe you can refactor into utils and/or core? Look at all 3 implementations in antd, chakra-ui and core

Those functions are rangeOptions, dateElementProps and readyForChange. Then we can look into reimplementing #1681 into the common rangeOptions function at the same time. It also seems like DateElement could be implemented exactly the same for the three themes as well.

@nickgros nickgros added the p1 Important to fix soon label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p1 Important to fix soon
Projects
None yet
Development

No branches or pull requests

2 participants