Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxIn registers have REG_OUT flag set. #59

Open
Rot127 opened this issue Apr 9, 2022 · 0 comments
Open

RxIn registers have REG_OUT flag set. #59

Rot127 opened this issue Apr 9, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@Rot127
Copy link
Member

Rot127 commented Apr 9, 2022

Rx and RxIn are set separately in hi->ops although they are the same register (Rx registers are used for input and output).
But the register attribute for RxIn is set to HEX_OP_REG_OUT although it is an "in" register.

The attribute is falsely assigned here:

if op.is_out_operand:
code += "hi->ops[{}].attr |= HEX_OP_REG_OUT;\n".format(op.syntax_index)

Currently the attributes are not used. So there is not much damage.

@Rot127 Rot127 added the bug Something isn't working label Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant