Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRefs window for a flag with very long name width is much greater than the screen width. #3300

Open
1 of 3 tasks
XVilka opened this issue Feb 24, 2024 · 1 comment
Open
1 of 3 tasks
Labels
good first issue Easy issues for new comers. UI

Comments

@XVilka
Copy link
Member

XVilka commented Feb 24, 2024

Environment information

  • Operating System: Windows
  • Cutter version: 2.3.3
  • Obtained from:
    • Built from source
    • Downloaded release from Cutter website or GitHub
    • Distribution repository
  • File format: PE

Describe the bug

Too long window containing the name of the flag goes beyond the edge of the screen, if the flag name is sufficiently long enough

image

To Reproduce

Steps to reproduce the behavior:

  1. Go to "Flags" widget
  2. Right click on any flag with very long name
  3. Select "XRefs"
  4. See error

Expected behavior

Cut the title/name to fit the screen properly.

@XVilka XVilka added good first issue Easy issues for new comers. UI labels Feb 24, 2024
@karliss
Copy link
Member

karliss commented Feb 24, 2024

The GUI still should be fixed on cutter side.

But maybe also automatically generated flag names for strings should limited on rizin side. I don't see the point in including x KB of xml file as a flag name for string. Possibly prefixed with a length and address when the length limit kicks in to help disambiguate them. That doesn't mean all flag names need to be limited, only automatically generated ones, user should still be allowed to set the name to whatever they want. For now also not suggesting anything for function or other symbol flags, since those are more likely to have somewhat reasonable size, mangled template names can be a bit crazy but nowhere near as bad as giant XML or other textfiles embedded as strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Easy issues for new comers. UI
Projects
Status: No status
Development

No branches or pull requests

2 participants