update: versioninfo copy fix code

rizinorg · Mar 18, 2024 · 7fb3965 · 7fb3965
1 parent 84fac11
commit 7fb3965
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 13 deletions.
diff --git a/src/dialogs/VersionInfoDialog.cpp b/src/dialogs/VersionInfoDialog.cpp
@@ -57,8 +57,6 @@ VersionInfoDialog::VersionInfoDialog(QWidget *parent)
 
  ui->rightTreeWidget->addAction(copyActionRightTreewidget);
  ui->rightTreeWidget->addAction(selAllActionRightTreewidget);
-
- contextMenu = new QMenu(this);
 }
 
 VersionInfoDialog::~VersionInfoDialog() {}
@@ -68,21 +66,20 @@ void VersionInfoDialog::CopyTreeWidgetSelection(QTreeWidget *t)
  const int keyColumnIndex = 0, valueColumnIndex = 1;
  QString vinfo, row;
 
- for (QTreeWidgetItem *x : t->selectedItems()) {
- row = x->text(keyColumnIndex) + " = " + x->text(valueColumnIndex) + "\n";
- vinfo.append(row);
+ QTreeWidgetItemIterator it(t);
+
+ while (*it) {
+ if ((*it)->isSelected()) {
+ row = (*it)->text(keyColumnIndex) + " = " + (*it)->text(valueColumnIndex) + "\n";
+ vinfo.append(row);
+ }
+ it++;
  }
 
  QClipboard *clipboard = QApplication::clipboard();
  clipboard->setText(vinfo.trimmed());
 }
 
-void VersionInfoDialog::contextMenuEvent(QContextMenuEvent *event)
-{
- contextMenu->exec(event->globalPos());
- event->accept();
-}
-
 void VersionInfoDialog::fillVersionInfo()
 {
  RzCoreLocked core(Core());

diff --git a/src/dialogs/VersionInfoDialog.h b/src/dialogs/VersionInfoDialog.h
@@ -28,8 +28,6 @@ private slots:
  QAction *selAllActionLeftTreewidget = nullptr;
  QAction *selAllActionRightTreewidget = nullptr;
 
- void contextMenuEvent(QContextMenuEvent *event) override;
-
 private:
  std::unique_ptr<Ui::VersionInfoDialog> ui;
  CutterCore *core;