Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENABLE_GITHUB_API_PREVIEW only checks against requiresStrictStatusChecks and not requiresStatusChecks #1210

Open
frankieyan opened this issue Nov 30, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@frankieyan
Copy link

What do you want to achieve?

Hey there 馃憢 I'm trying to have the action go through only when other status checks are complete. These are split into separate workflows, so what ends up happening is that the action passes and the PR is merged before other workflows are finished.

This seems to be happening because only requiresStrictStatusChecks is being checked, which looks like it only covers the Require branches to be up to date before merging option:

We don't have this option turned on in our repo, so this returns false even though mergeStateStatus is BLOCKED for the branch and the merge goes through. Is what I'm looking for possible if requiresStatusChecks is also checked?

Alternatively, is it possible to expose an option to use the enablePullRequestAutoMerge mutation rather than mergePullRequest?

I'm happy to help contribute to this change 馃憤

What is the current way of working?

We don't have a workaround right now, other than having the DEPENDABOT_MINOR preset in place, but breaking changes still manage to sneak in because our other status checks are being ignored.

How much does it hurt?

It's painful! 馃檭

@frankieyan frankieyan added the enhancement New feature or request label Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant