Integrate tgcca #76
Draft
Integrate tgcca #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Instead of dividing by std which might be null, we divide by the max between std and machine precision for floats * Since some variables may be null, we always divide by the frobenius norm and not by the number of variables once scaled
Since we do not remove constant variables anymore we do no longer need a specific strategy for sampling bootstrap samples.
I chose to scale arrays by unfolding them, scaling the resulting matrices and fold them back. It may not be the adapted way to scale a tensor. It will be interesting to have a string argument for the scale parameter to allow choosing the best strategy.
comp_orth = TRUE yields orthogonal canonical components but comp_orth = FALSE does not lead yet to orthogonal canonical vectors
* Important change in this version: tau and sparsity are converted to matrices directly in select_analysis
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 94.39% 90.56% -3.83%
==========================================
Files 83 82 -1
Lines 3319 3212 -107
==========================================
- Hits 3133 2909 -224
- Misses 186 303 +117 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.