Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rgcca jss #74

Merged
merged 23 commits into from
Oct 5, 2023
Merged

Rgcca jss #74

merged 23 commits into from
Oct 5, 2023

Conversation

Tenenhaus
Copy link
Collaborator

No description provided.

GFabien and others added 23 commits July 18, 2023 10:36
typo in the print message of the fitted rgcca object
 (i) rephrase part of the introduction,
 (ii) reorganization of Section 2.
 (iii) minor changes for Glioma
* First introduce RGCCA and its framework
* Show how it generalizes many existing methods
* Show how SGCCA positions itself
* Introduce the algorithm for the RGCCA framework
* Detail the specific parts for RGCCA and SGCCA
* Use \citep instead of \cite if the citation is not really part of the sentence, and avoid putting parentheses inside parentheses
* Change Sections description
* Add ggplot2 citation
* Systematically use special formatting for package names
* Insert commas after i.e. and e.g.
* Insert quotes when using commands library() and data()
* Remove comments
* Use (\ref{}) or Equation~\ref{}
* Use \proglang, \pkg and \code
* Follow recommendations on publishers' names
* Write \section and \subsection in sentence style
* Remove capitalization of abbreviations' extensions
@codecov-commenter
Copy link

Codecov Report

Merging #74 (594b52a) into main (068c561) will decrease coverage by 0.23%.
The diff coverage is 91.87%.

❗ Current head 594b52a differs from pull request most recent head 07574ba. Consider uploading reports for the commit 07574ba to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   94.62%   94.39%   -0.23%     
==========================================
  Files          78       83       +5     
  Lines        3274     3319      +45     
==========================================
+ Hits         3098     3133      +35     
- Misses        176      186      +10     
Files Coverage Δ
R/as_disjunctive.r 93.33% <100.00%> (-0.42%) ⬇️
R/print.rgcca_bootstrap.R 100.00% <100.00%> (ø)
R/print.rgcca_permutation.R 100.00% <100.00%> (ø)
R/print.rgcca_stability.R 100.00% <100.00%> (ø)
R/rgcca.R 89.47% <ø> (ø)
R/rgcca_bootstrap.R 89.79% <ø> (ø)
R/rgcca_bootstrap_k.R 97.05% <100.00%> (+0.18%) ⬆️
R/rgcca_cv.r 97.16% <100.00%> (+0.02%) ⬆️
R/rgcca_stability.R 77.27% <100.00%> (+0.34%) ⬆️
R/summary.rgcca.R 100.00% <100.00%> (ø)
... and 7 more

@Tenenhaus Tenenhaus merged commit 0329f1e into main Oct 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants