-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rgcca jss #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typo in the print message of the fitted rgcca object
(i) rephrase part of the introduction, (ii) reorganization of Section 2. (iii) minor changes for Glioma
* First introduce RGCCA and its framework * Show how it generalizes many existing methods * Show how SGCCA positions itself * Introduce the algorithm for the RGCCA framework * Detail the specific parts for RGCCA and SGCCA
* Use \citep instead of \cite if the citation is not really part of the sentence, and avoid putting parentheses inside parentheses * Change Sections description * Add ggplot2 citation * Systematically use special formatting for package names
* Insert commas after i.e. and e.g. * Insert quotes when using commands library() and data() * Remove comments * Use (\ref{}) or Equation~\ref{} * Use \proglang, \pkg and \code * Follow recommendations on publishers' names * Write \section and \subsection in sentence style * Remove capitalization of abbreviations' extensions
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 94.62% 94.39% -0.23%
==========================================
Files 78 83 +5
Lines 3274 3319 +45
==========================================
+ Hits 3098 3133 +35
- Misses 176 186 +10
|
GFabien
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.