flushall and flushdb vs namespaces

[yaauie]

Since these are especially destructive (beyond the scope of the namespace) and rather surprising to anyone who would think that namespacing provides segregation, perhaps #flushall and #flushdb should be blocked in a future version, requiring the user to use RedisNamespace#redis directly.

[steveklabnik]

Yeah. This will cause lots of havok in the Resque tests....

[carlzulauf]

👍

[yaauie]

@steveklabnik definitely in a major version release if at all. The trouble is that the documentation claims that this wrapper "Namespaces all Redis calls", and yet it doesn't. Same for #34.

The actual behaviour is very surprising in a very destructive way, so either that needs to stop happening or the documentation needs to be updated to something like "Namespaces most Redis calls that we know and care about, but lets the rest pass through unchanged" 😄.

[plukevdh]

Does this mean that there is no way to flush a namespace?

[yaauie]

@plukevdh yes, that is correct.

[dmitry]

We are doing it currently like redis.del(redis.keys('*')) in our tests (or previously redis.keys('*').each { |key| redis.del(key) }). And I guess there are no better way of doing the same thing.

👍 for #flushall and #flushdb to raise an error and use redis directly instead of current behaviour.

[yaauie]

@dmitry if your redis-server supports it (versions >= 2.7.105), scan is a lot safer (and the ruby adapter has scan_each which behaves a lot like keys)

[dmitry]

@yaauie thanks for the suggestion. We have parallel tests that are isolated by the redis-namespace and they are running in sequential flow, so the keys + del is enough for us for this task.

[Fryie]

Thanks @dmitry. I believe you also have to wrap that call, since del fails on an empty array:

if redis.keys.any?
  redis.del(redis.keys)
end

[dmitry]

@Fryie yes, that's right. To prevent from 2 calls, you have to use:

if (keys = redis.keys) && !keys.empty?
  redis.del(keys)
end

[richhollis]

Would there be any value in adding a new method that just deletes the namespaced keys? I could submit a PR if there is.

[fatkodima]

So seems like this issue can be closed, because using them already produces a warning and will raise in 2.0 -

redis-namespace/lib/redis/namespace.rb

Lines 332 to 347 in f2f6016

	ADMINISTRATIVE_COMMANDS.keys.each do |command|
	define_method(command) do |*args, &block|
	raise NoMethodError if deprecations?
	if warning?
	warn("Passing '#{command}' command to redis as is; " +
	"administrative commands cannot be effectively namespaced " +
	"and should be called on the redis connection directly; " +
	"passthrough has been deprecated and will be removed in " +
	"redis-namespace 2.0 (at #{call_site})"
	)
	end
	call_with_namespace(command, *args, &block)
	end
	ruby2_keywords(command) if respond_to?(:ruby2_keywords, true)
	end

Would there be any value in adding a new method that just deletes the namespaced keys? I could submit a PR if there is.

Makes sense to me.