Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespace nil key #107

Closed
wants to merge 1 commit into from
Closed

namespace nil key #107

wants to merge 1 commit into from

Conversation

ghprince
Copy link

@ghprince ghprince commented Jul 7, 2015

closes #106 nil key should also be namespaced

@yaauie
Copy link
Member

yaauie commented Jul 7, 2015

While I appreciate the work you put into this, as noted in #106, defining behaviour here where it is undefined upstream (in the redis ruby adapter) is somewhat dangerous; I would be more inclined to guard against receiving nil as a key (e.g., raise an ArgumentError) than to formalize the observed behaviour. I'm closing this PR for now, but leaving #106 open so we can decide what to do with unexpected input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nil key should also be namespaced
3 participants