Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Request header inspection doesn't work for Accept-Encoding. [Mac Desktop] #1445

Open
1 of 4 tasks
lukesneeringer opened this issue Feb 22, 2024 · 2 comments
Open
1 of 4 tasks
Assignees
Labels
desktop_app issue Distinguish between PR and Issue type: bug

Comments

@lukesneeringer
Copy link

lukesneeringer commented Feb 22, 2024

Describe your issue?

I downloaded requestly because I wanted to know what headers I was sending to a server, and the tool I was using (reqwest crate for Rust) doesn't have an easy way to be verbose about a request.

This basic functionality doesn't work, although this appears to be limited to the Accept-Encoding header.

Repro steps

My reproduction case is as follows:

  1. Download the current Mac client (1.6.0), install disk image, open app, run the terminal command to enable interception (. <(curl -sS localhost:7040/tpsetup)).
  2. Send several basic curl commands with distinct Accept-Encoding headers:
  • curl -I -v https://google.com/
  • curl -I -v https://google.com/ -H "Accept-Encoding: gzip"
  • curl -I -v https://google.com/ -H "Accept-Encoding: brotli"
  • curl -I -v https://google.com/ -H "Accept-Encoding: identity"
  1. Observe that they all have an accept-encoding: gzip header.

What Requestly tool were you using?

  • Extension
  • Desktop-App
  • Android SDK
  • Selenium

Your Environment

MacOS

Requestly Version

v1.6.0

Error screenshot

Screenshot 2024-02-22 at 10 58 32

Screenshot 2024-02-22 at 10 58 59

@echo-sg
Copy link

echo-sg commented Feb 25, 2024

Thank you for raising this, we'll check for the issue at our end and revert soon.

@nsrCodes
Copy link
Contributor

nsrCodes commented Mar 4, 2024

Our proxy middleware splits the original connection ( client -> server) into two parts (client -> proxy and proxy -> server) with some pre-defined assumptions. Overriding the accept-encoding is one of those assumptions.

This needs to be fixed since this could also be a likely cause for #271

Thanks for pointing this out, we will try to address this ASAP

@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
@nsrCodes nsrCodes reopened this Mar 4, 2024
@wrongsahil wrongsahil added the issue Distinguish between PR and Issue label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop_app issue Distinguish between PR and Issue type: bug
Projects
None yet
Development

No branches or pull requests

4 participants