-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMD+click does not open a tab #609
Comments
This is a degradation of accessibility. 🙁 |
The teasers themselves aren't anchor tags. They used to be, but that implementation caused a bunch of issues and was also invalid HTML, that's why it was removed. The titles on the teasers, however, are wrapped in an anchor tag,
Perhaps we can look into adding a custom click handler on the teasers themselves sometime when we have more time on our hands. (Unfortunately, this isn't quite as trivial as one would think with the current front implementation) |
You could just wrap the image in anchor tags (more like a secondary click area). |
I cannot confirm that CMD+click on the title wrapped in an a-tag in the current state brings the desired effect. Just tested with Firefox 118.0 (64-bit) on MacOS 10.15.7 (19H2026). A quick google tells me that |
Unfortunately, it's not so trivial. As mentioned the current implementation sadly doesn't allow us to easily manipulate the rendering-schema, so getting this to work properly won't be as easy as one would think. @petarmarj Either way, we can look into this at some point, but right now we don't have resources to spare. |
@trm217 where is the template/schema for the teaser? |
Well, then I'll see what possibilities I have as a subscriber to create the appropriate resources for you. I'm sure I'll find some say if it doesn't work here via Github. |
I believe we've been relying on a behavior of next.js' Link component that doesn't seem to work anymore (i.e. attaching an onClick handler on any element that's wrapped inside – not just links). There are better (CSS-only) solutions but getting this right is a bit more involved: |
Bug Description
Since one of the more recent updates, users can no longer use the established shortcut CMD/CTRL+click to open an article in a new tab.
Expected Behaviour
CMD/CTRL+click opens link in new tab.
Steps to reproduce
CMD/CTRL+click on a teaser on the front. The article opens in the same frame.
Environment
Chrome
Version
Concerns Chrome and Firefox, version-independent, as dependent on implemented Javascript handling.
The text was updated successfully, but these errors were encountered: