129 a11y communicate activeselected state of navigationselection elements #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elected-state-of-navigationselection-elements
…-navigationselection-elements
… list & set roles
…-navigationselection-elements
3 tasks
trm217
added
app: www
…-navigationselection-elements
ovbm
reviewed
Aug 5, 2022
| @@ -1,5 +1,5 @@ | |||
| import { css } from 'glamor' | |||
| import React, { useRef, useState, useEffect } from 'react' | |||
| import React, { useRef, useState, useEffect, Children } from 'react' | |||
There was a problem hiding this comment.
Changes in the Scroller don't seem related to acessibility. I don't have time to check these now. Has this been tested? Seems to me that it would change layout behavior.
There was a problem hiding this comment.
You're right, that wasn't an issue mentioned in the issue. However this changes were made to make the tab buttons to be easier accessbile by wrapping them in a list as well as passing certain a11y-attributes. It shouldn't change the functionality, but if you could test it as well that'd be cool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issues mentioned in #129
Todo