Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish step undefined status #94

Closed

Conversation

dgosantos89
Copy link

I had the same problem that was reported at Issue 58 and Issue 64

Some steps was marked with In progress, because the step was undefined, so my solution is finish all steps that was undefined status as SKIPPED status

@orgads
Copy link

orgads commented Jul 12, 2023

@AmsterGet ping?

@AmsterGet
Copy link
Member

Hi guys!
I'm going to review the PR this week.

@AmsterGet AmsterGet self-requested a review July 18, 2023 10:58
@dgosantos89
Copy link
Author

Hi @AmsterGet!
Any news about this fix?

@brunotanoue
Copy link

Hi @AmsterGet. How are you?

I'm really interested to use reportportal in my company with Postman and Azure Pipelines, but the issues 58 and 64 are resulting in undefined status in some cases. Is there any deadline?

@@ -441,7 +456,7 @@ class Reporter {
finishSuite () {
const currentSuiteTempId = this.getCurrentSuiteTempId();
const status = this.collectionRunOptions.collection &&
utils.getCollectionVariablesByKey('status', this.collectionRunOptions.collection.variables);
utils.getCollectionVariablesByKey('status', this.collectionRunOptions.collection.variables) || 'PASSED';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ReportPortal API will calculate the final suite status based on the statuses of its descendants, so setting here PASSED as a fallback may lead to wrong suite status in the system.

lib/reporter.js Outdated Show resolved Hide resolved
@AmsterGet
Copy link
Member

Hi guys!
Sorry, there have been very busy weeks and unexpected leaves in the team.

Thanks @dgosantos89 for the solution. Please check my comments above.

@brunotanoue Good to hear that.
We plan to release a fix once it's merged, so it might take some time.
Also, @Bam6ycha is currently working on a backquoted test names issue fix (#60) and we plan to release those fixes together.

We will keep you updated in this topic.

@Bam6ycha
Copy link
Contributor

Hi,@dgosantos89. I hope you are doing well.
This issue was fixed by the already merged PR.
We really appreciate you for your help and time.

This issue occurred because we didn't support conditional tests.
That is why we decided to implement this feature in the next releases.

@Bam6ycha
Copy link
Contributor

Closed due to irrelevance

@Bam6ycha Bam6ycha closed this Aug 28, 2023
@Bam6ycha
Copy link
Contributor

@dgosantos89, FYI: The new version of the agent has been released. You can test it out with your tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants