Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect is not expose in Modal for Vanilla JS #60

Open
SerhiiKirik opened this issue Sep 19, 2024 · 3 comments
Open

Disconnect is not expose in Modal for Vanilla JS #60

SerhiiKirik opened this issue Sep 19, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@SerhiiKirik
Copy link

Describe the bug

There seems to be an error in the documentation in the Actions section for JavaScript (wagmi).
Link: DOC

Specifically in the Disconnect section:

modal.disconnect()

The issue is that modal does not have a disconnect method. Previously, disconnect was implemented using wagmi as follows:

import { disconnect } from '@wagmi/core';

I might be mistaken, and I would be happy to hear your response.
Thank you!

@SerhiiKirik SerhiiKirik added the bug Something isn't working label Sep 19, 2024
@SerhiiKirik
Copy link
Author

Additional Comment:

I found the ConnectionController which contains a disconnect method. Therefore, we can do something like this:

await ConnectionController.disconnect();

Would this be the correct approach? Or is there a better way to handle the disconnect?

Also, the documentation lacks methods for tracking connection status, loading states, and the account. It would be helpful to add these.

@rtomas
Copy link
Collaborator

rtomas commented Oct 3, 2024

Error already know an reported . thanks
https://linear.app/reown/issue/APKT-1045/[bug]-disconnect-is-not-expose

@rtomas
Copy link
Collaborator

rtomas commented Oct 3, 2024

meanwhile you can use
modal.adapter?.connectionControllerClient?.disconnect()

@rtomas rtomas changed the title Issue in JavaScript Documentation (wagmi) - Actions Section Disconnect is not expose in Modal for Vanilla JS Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants