Dependency Dashboard shows everything as "awaiting schedule" rather than "open" when updateNotScheduled is false

[anomiex]

What Renovate type, platform and version are you using?

Hosted app. Github.

Describe the bug

Automattic/jetpack#19284 shows everything under "Awaiting Schedule". I'd expect the ones that have an open PR to be listed under "Open" instead.

PRs only show up under "Open" when I check the checkbox to ignore the schedule, then the next run will move them to "Open". And then they'll move back to "Awaiting Schedule" again on the next run.

Relevant debug logs

Here's an excerpt from https://app.renovatebot.com/dashboard#github/Automattic/jetpack/323280505

DEBUG: processBranch with 58 upgrades(branch="renovate/pin-dependencies")
DEBUG: Setting current branch to master(branch="renovate/pin-dependencies")
DEBUG: latest commit(branch="renovate/pin-dependencies")
{
  "branchName": "master",
  "latestCommitDate": "2021-03-24T15:34:38-04:00"
}
DEBUG: getBranchPr(renovate/pin-dependencies)(branch="renovate/pin-dependencies")
DEBUG: findPr(renovate/pin-dependencies, undefined, open)(branch="renovate/pin-dependencies")
DEBUG: Found PR #19291(branch="renovate/pin-dependencies")
DEBUG: PR not found in open or closed PRs list - trying to fetch it directly(branch="renovate/pin-dependencies")
{
  "prNo": 19291
}
DEBUG: branchExists=true(branch="renovate/pin-dependencies")
DEBUG: Branch pr rebase requested: false(branch="renovate/pin-dependencies")
DEBUG: Branch has 25 upgrade(s)(branch="renovate/pin-dependencies")
DEBUG: Checking if PR has been edited(branch="renovate/pin-dependencies")
DEBUG: Found existing branch PR(branch="renovate/pin-dependencies")
DEBUG: Checking schedule(before 3am on the first day of the month, UTC)(branch="renovate/pin-dependencies")
DEBUG: Found timezone(branch="renovate/pin-dependencies")
{
  "timezone": "UTC"
}
DEBUG: Adjusting now for timezone(branch="renovate/pin-dependencies")
DEBUG: Checking 1 schedule(s)(branch="renovate/pin-dependencies")
DEBUG: Checking schedule "before 3am on the first day of the month"(branch="renovate/pin-dependencies")
{
  "parsedSchedule": {
    "schedules": [
      {
        "t_b": [
          10800
        ],
        "D": [
          1
        ]
      }
    ],
    "exceptions": [],
    "error": -1
  }
}
DEBUG: schedule.D(branch="renovate/pin-dependencies")
{
  "schedule_D": [
    1
  ]
}
DEBUG: Package not scheduled(branch="renovate/pin-dependencies")
DEBUG: Skipping branch update as not within schedule(branch="renovate/pin-dependencies")

Have you created a minimal reproduction repository?

Please read the minimal reproductions documentation to learn how to make a good minimal reproduction repository.

• This is a really small bug, it does not need a reproduction (think small typo)
• I have provided a minimal reproduction repository
• I don't have time for that, but it happens in a public repository I have linked to
• I don't have time for that, and cannot share my private repository
• The nature of this bug means it's impossible to reproduce publicly

Reproduction repo is https://github.com/anomiex/renovate-test

Additional context

I suspect you might fix this by changing

renovate/lib/workers/branch/index.ts

Lines 247 to 255 in 3ae05a2

	if (config.updateNotScheduled === false && !config.rebaseRequested) {
	logger.debug('Skipping branch update as not within schedule');
	return ProcessBranchResult.NotScheduled;
	}
	// istanbul ignore if
	if (!branchPr) {
	logger.debug('Skipping PR creation out of schedule');
	return ProcessBranchResult.NotScheduled;
	}

to

      // istanbul ignore if
      if (!branchPr) {
        logger.debug('Skipping PR creation out of schedule');
        return ProcessBranchResult.NotScheduled;
      }
      if (config.updateNotScheduled === false && !config.rebaseRequested) {
        logger.debug('Skipping branch update as not within schedule');
        return ProcessBranchResult.Done;
      }

Or create a new ProcessBranchResult constant if you don't want to reuse Done.

[rarkins]

Although a reproduction is always best, we might try fixing this through code inspection alone as proposed.

[anomiex]

It was past the end of my day yesterday when I filed this. I've now created a reproduction repo at https://github.com/anomiex/renovate-test.

• https://app.renovatebot.com/dashboard#github/anomiex/renovate-test/323793091 is the initial run on the repo, which created the dashboard in that repo.
• https://app.renovatebot.com/dashboard#github/anomiex/renovate-test/323793099 is where I checked the checkbox to ignore the schedule so it would create Pin dependency automattic/jetpack-changelogger to v2.0.1 - autoclosed anomiex/renovate-test#2
• https://app.renovatebot.com/dashboard#github/anomiex/renovate-test/323793104 is where I checked the "Check this box to trigger a request for Renovate to run again on this repository" checkbox to have it re-run and reproduce the bug.

[github-actions]

Thank you for providing a reproduction! 🎉 🚀

The Renovate team will take a look at the reproduction repository. Once we confirm the provided repository reproduces the problem, the label will be changed to reproduction:confirmed.

[renovate-release]

🎉 This issue has been resolved in version 25.37.2 🎉

The release is available on:

• GitHub release
• 25.37.2

Your semantic-release bot 📦🚀

[rarkins]