Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: sort sub-headings of options #29798

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

refactor: sort sub-headings of options #29798

wants to merge 5 commits into from
+360 −310

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • Add test to validate the sub headings are sorted
  • edit the order of sub-headings to match alphabetical order

Context

Closes: #29703

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 21, 2024
View reviewed changes
test/documentation.spec.ts Fixed Show fixed Hide fixed
@RahulGautamSingh RahulGautamSingh changed the title docs: sort sub-headings of options refactor: sort sub-headings of options Jun 21, 2024
viceice
viceice reviewed Jun 21, 2024
View reviewed changes
test/documentation.spec.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rarkins rarkins rarkins approved these changes

@HonkingGoose HonkingGoose Awaiting requested review from HonkingGoose

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort packageRules in docs, validate with tests
3 participants
@RahulGautamSingh @viceice @rarkins