Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab CODEOWNERS: support for default section owner #29202

Open
rarkins opened this issue May 22, 2024 Discussed in #29182 · 0 comments
Open

GitLab CODEOWNERS: support for default section owner #29202

rarkins opened this issue May 22, 2024 Discussed in #29182 · 0 comments
Labels
help wanted Help is needed or welcomed on this issue platform:gitlab GitLab Platform priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented May 22, 2024

Discussed in #29182

Originally posted by balihb May 21, 2024

Tell us more.

Gitlab supports sections in CODEOWNERS and can assign default owners for sections.
https://docs.gitlab.com/ee/user/project/codeowners/index.html#set-default-owner-for-a-section

This section must be refactored to support it:

    // Convert CODEOWNERS file into list of matching rules
    const fileOwnerRules = codeOwnersFile
      .split(newlineRegex)
      // Remove comments
      .map((line) => line.split('#')[0])
      // Remove empty lines
      .map((line) => line.trim())
      .filter(is.nonEmptyString)
      // Extract pattern & usernames
      .map(extractOwnersFromLine);
@rarkins rarkins added type:feature Feature (new functionality) help wanted Help is needed or welcomed on this issue priority-4-low Low priority, unlikely to be done unless it becomes important to more people platform:gitlab GitLab Platform labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Help is needed or welcomed on this issue platform:gitlab GitLab Platform priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

1 participant