Raw HTML rendering instead of HTML table in BitBucket PR Description #8121

leifjones · 2020-12-22T17:16:58Z

leifjones
Dec 22, 2020

What Renovate type, platform and version are you using?

BitBucket Cloud via bitbucket-pipelines.yml, using the renovate/renovate:24.10.1-slim image

Describe the bug

For at least an "Update angularcli monorepo" PR, the table detailing release notes for angular/angular-cli is rendering actual html tags, instead of a table. See images provided below

Relevant debug logs

DEBUG: No automerge (repository=DEBUG: No automerge (repository=my/repo, branch=renovate/angular-monorepo)
DEBUG: getBranchPr(renovate/angularcli-monorepo) (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: findPr(renovate/angularcli-monorepo, undefined, open) (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: getPrList() (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: processBranch with 3 upgrades (repository=my/repo, dependencies=@angular-devkit/build-angular,@angular/cli,@ngtools/webpack, branch=renovate/angularcli-monorepo)
DEBUG: Setting current branch to dev (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: latest commit (repository=my/repo, branch=renovate/angularcli-monorepo)
       "branchName": "dev",
       "latestCommitDate": "2020-12-22T16:26:12+00:00"
DEBUG: getBranchPr(renovate/angularcli-monorepo) (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: findPr(renovate/angularcli-monorepo, undefined, open) (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: getPrList() (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: branchExists=false (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Branch has 3 upgrade(s) (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: recreateClosed is true (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Checking schedule(at any time, null) (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: No schedule defined (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Branch needs creating (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Using reuseExistingBranch: false (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: manager.getUpdatedPackageFiles() (repository=my/repo, branch=renovate/angularcli-monorepo)
       "reuseExistingBranch": false,
       "branchName": "renovate/angularcli-monorepo"
DEBUG: npm.updateDependency(): dependencies.@angular-devkit/build-angular = 0.1100.5 (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Updating packageFile content (repository=my/repo, packageFile=mysubproject/src/main/webapp/package.json, branch=renovate/angularcli-monorepo)
       "depName": "@angular-devkit/build-angular"
DEBUG: npm.updateDependency(): devDependencies.@angular/cli = 10.2.1 (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Updating packageFile content (repository=my/repo, packageFile=myothersubproject/package.json, branch=renovate/angularcli-monorepo)
       "depName": "@angular/cli"
DEBUG: npm.updateDependency(): devDependencies.@ngtools/webpack = 10.2.1 (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Updating packageFile content (repository=my/repo, packageFile=myothersubproject/package.json, branch=renovate/angularcli-monorepo)
       "depName": "@ngtools/webpack"
DEBUG: Updated 2 package files (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Getting updated lock files (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: lock file dirs (repository=my/repo, branch=renovate/angularcli-monorepo)
       "dirs": {
         "yarnLockDirs": [],
         "npmLockDirs": [],
         "pnpmShrinkwrapDirs": [],
         "lernaDirs": []
       }
DEBUG: Writing package.json files (repository=my/repo, branch=renovate/angularcli-monorepo)
       "packageFiles": ["mysubproject/src/main/webapp/package.json", "myothersubproject/package.json"]
DEBUG: Writing any updated package files (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Writing mysubproject/src/main/webapp/package.json (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Writing myothersubproject/package.json (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: No updated lock files in branch (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: 2 file(s) to commit (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Committing files to branch renovate/angularcli-monorepo (repository=my/repo, branch=renovate/angularcli-monorepo)
 INFO: Branch created (repository=my/repo, branch=renovate/angularcli-monorepo)
       "commitSha": "cd44fe6"
DEBUG: Ensuring PR (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: There are 0 errors and 0 warnings (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: getBranchPr(renovate/angularcli-monorepo) (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: findPr(renovate/angularcli-monorepo, undefined, open) (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: getPrList() (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Removing duplicate release notes (repository=my/repo, branch=renovate/angularcli-monorepo)
       "depName": "@ngtools/webpack"
DEBUG: Creating PR (repository=my/repo, branch=renovate/angularcli-monorepo)
       "prTitle": "Update angularcli monorepo"
DEBUG: Creating PR (repository=my/repo, branch=renovate/angularcli-monorepo)
       "title": "Update angularcli monorepo",
       "base": "dev"
 INFO: PR created (repository=my/repo, branch=renovate/angularcli-monorepo)
       "pr": 874,
       "prTitle": "Update angularcli monorepo"
DEBUG: Created Pull Request #874 (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Checking #874 for automerge (repository=my/repo, branch=renovate/angularcli-monorepo)
       "automerge": false,
       "automergeType": "pr",
       "automergeComment": "automergeComment"
DEBUG: No automerge (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: getBranchPr(renovate/ng-bootstrap-ng-bootstrap-6.x) (repository=my/repo, branch=renovate/ng-bootstrap-ng-bootstrap-6.x), branch=renovate/angular-monorepo)
DEBUG: getBranchPr(renovate/angularcli-monorepo) (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: findPr(renovate/angularcli-monorepo, undefined, open) (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: getPrList() (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: processBranch with 3 upgrades (repository=my/repo, dependencies=@angular-devkit/build-angular,@angular/cli,@ngtools/webpack, branch=renovate/angularcli-monorepo)
DEBUG: Setting current branch to dev (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: latest commit (repository=my/repo, branch=renovate/angularcli-monorepo)
       "branchName": "dev",
       "latestCommitDate": "2020-12-22T16:26:12+00:00"
DEBUG: getBranchPr(renovate/angularcli-monorepo) (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: findPr(renovate/angularcli-monorepo, undefined, open) (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: getPrList() (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: branchExists=false (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Branch has 3 upgrade(s) (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: recreateClosed is true (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Checking schedule(at any time, null) (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: No schedule defined (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Branch needs creating (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Using reuseExistingBranch: false (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: manager.getUpdatedPackageFiles() (repository=my/repo, branch=renovate/angularcli-monorepo)
       "reuseExistingBranch": false,
       "branchName": "renovate/angularcli-monorepo"
DEBUG: npm.updateDependency(): dependencies.@angular-devkit/build-angular = 0.1100.5 (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Updating packageFile content (repository=my/repo, packageFile=mysubproject/src/main/webapp/package.json, branch=renovate/angularcli-monorepo)
       "depName": "@angular-devkit/build-angular"
DEBUG: npm.updateDependency(): devDependencies.@angular/cli = 10.2.1 (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Updating packageFile content (repository=my/repo, packageFile=myothersubproject/package.json, branch=renovate/angularcli-monorepo)
       "depName": "@angular/cli"
DEBUG: npm.updateDependency(): devDependencies.@ngtools/webpack = 10.2.1 (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Updating packageFile content (repository=my/repo, packageFile=myothersubproject/package.json, branch=renovate/angularcli-monorepo)
       "depName": "@ngtools/webpack"
DEBUG: Updated 2 package files (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Getting updated lock files (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: lock file dirs (repository=my/repo, branch=renovate/angularcli-monorepo)
       "dirs": {
         "yarnLockDirs": [],
         "npmLockDirs": [],
         "pnpmShrinkwrapDirs": [],
         "lernaDirs": []
       }
DEBUG: Writing package.json files (repository=my/repo, branch=renovate/angularcli-monorepo)
       "packageFiles": ["mysubproject/src/main/webapp/package.json", "myothersubproject/package.json"]
DEBUG: Writing any updated package files (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Writing mysubproject/src/main/webapp/package.json (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Writing myothersubproject/package.json (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: No updated lock files in branch (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: 2 file(s) to commit (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Committing files to branch renovate/angularcli-monorepo (repository=my/repo, branch=renovate/angularcli-monorepo)
 INFO: Branch created (repository=my/repo, branch=renovate/angularcli-monorepo)
       "commitSha": "cd44fe6"
DEBUG: Ensuring PR (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: There are 0 errors and 0 warnings (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: getBranchPr(renovate/angularcli-monorepo) (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: findPr(renovate/angularcli-monorepo, undefined, open) (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: getPrList() (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Removing duplicate release notes (repository=my/repo, branch=renovate/angularcli-monorepo)
       "depName": "@ngtools/webpack"
DEBUG: Creating PR (repository=my/repo, branch=renovate/angularcli-monorepo)
       "prTitle": "Update angularcli monorepo"
DEBUG: Creating PR (repository=my/repo, branch=renovate/angularcli-monorepo)
       "title": "Update angularcli monorepo",
       "base": "dev"
 INFO: PR created (repository=my/repo, branch=renovate/angularcli-monorepo)
       "pr": 874,
       "prTitle": "Update angularcli monorepo"
DEBUG: Created Pull Request #874 (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: Checking #874 for automerge (repository=my/repo, branch=renovate/angularcli-monorepo)
       "automerge": false,
       "automergeType": "pr",
       "automergeComment": "automergeComment"
DEBUG: No automerge (repository=my/repo, branch=renovate/angularcli-monorepo)
DEBUG: getBranchPr(renovate/ng-bootstrap-ng-bootstrap-6.x) (repository=my/repo, branch=renovate/ng-bootstrap-ng-bootstrap-6.x)

Have you created a minimal reproduction repository?

Please read the minimal reproductions documentation to learn how to make a good minimal reproduction repository.

This is a really small bug, it does not need a reproduction (think small typo)
I have provided a minimal reproduction repository
I don't have time for that, but it happens in a public repository I have linked to
I don't have time for that, and cannot share my private repository
The nature of this bug means it's impossible to reproduce publicly

Additional context

Image of the top of the PR:

Image of the bottom of the PR:

rarkins · 2020-12-22T21:42:30Z

rarkins
Dec 22, 2020
Maintainer

This appears to be how those release notes are published: https://github.com/angular/angular-cli/releases/tag/v10.2.1

0 replies

leifjones · 2020-12-22T23:45:17Z

leifjones
Dec 22, 2020
Author

Aha, indeed. Thank you.

It seems there are potentially three different places this could be resolved:

BitBucket's rendering (would involve a request to Atlassian that they render tables)
Renovate processing the tables. (Renovate already successfully renders tables.)
Angular changing their release notes format

Since this convo is on the Renovate repo, how feasible/appropriate is #2?

0 replies

leifjones · 2020-12-22T23:46:21Z

leifjones
Dec 22, 2020
Author

@rarkins Does that explain how the html appears to be truncated at the bottom of the second screenshot?

0 replies

rarkins · 2020-12-23T06:54:52Z

rarkins
Dec 23, 2020
Maintainer

Release notes are sometimes intentionally truncated if the PR body length is too long. It may explain it, or maybe they are extracted wrong to begin with.

It is not feasible that Renovate will reverse engineer HTML tables into markdown (2).

0 replies

HonkingGoose · 2020-12-28T13:08:56Z

HonkingGoose
Dec 28, 2020
Collaborator

@rarkins I think this issue can be closed? I'll let you decide if you want to keep this issue around or close it.

0 replies

rarkins · 2020-12-28T13:10:24Z

rarkins
Dec 28, 2020
Maintainer

I wanted to first double check if our release notes disabling works as I remembered. If so then the solution is to disable release notes for this package on Bitbucket

0 replies

HonkingGoose · 2020-12-28T13:13:49Z

HonkingGoose
Dec 28, 2020
Collaborator

I wanted to first double check if our release notes disabling works as I remembered. If so then the solution is to disable release notes for this package on Bitbucket

Oh okay, I thought there was nothing we could do about this problem. I'll leave this issue open then. 😄

0 replies

rarkins · 2020-12-30T11:22:58Z

rarkins
Dec 30, 2020
Maintainer

This should remove the release notes for that package:

{
  "packageRules": [{
    "packageNames": ["@angular/cli"],
    "fetchReleaseNotes": false
  }]
}

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Raw HTML rendering instead of HTML table in BitBucket PR Description #8121

{{title}}

Replies: 8 comments

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Select a reply

Raw HTML rendering instead of HTML table in BitBucket PR Description #8121

leifjones Dec 22, 2020

Replies: 8 comments

rarkins Dec 22, 2020 Maintainer

leifjones Dec 22, 2020 Author

leifjones Dec 22, 2020 Author

rarkins Dec 23, 2020 Maintainer

HonkingGoose Dec 28, 2020 Collaborator

rarkins Dec 28, 2020 Maintainer

HonkingGoose Dec 28, 2020 Collaborator

rarkins Dec 30, 2020 Maintainer

leifjones
Dec 22, 2020

rarkins
Dec 22, 2020
Maintainer

leifjones
Dec 22, 2020
Author

leifjones
Dec 22, 2020
Author

rarkins
Dec 23, 2020
Maintainer

HonkingGoose
Dec 28, 2020
Collaborator

rarkins
Dec 28, 2020
Maintainer

HonkingGoose
Dec 28, 2020
Collaborator

rarkins
Dec 30, 2020
Maintainer