Documentation for ARG IMAGE= in dockerfile manager

[wwuck]

What would you like help with?

I would like help with my configuration

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

37.349.2

Please tell us more about your question or problem

I saw this comment #28834 (comment) on a recent PR so I thought I would be able to remove some of my existing regex manager configurations.

eg.

ARG IMAGE=node:12@sha256:6e5264cd4cfaefd7174b2bc10c7f9a1c2b99d98d127fc57a802d264da9fb43bd
FROM ${IMAGE}

I can't find any reference to this pattern anywhere in renovate docs to show what the expected syntax format should be in my Dockerfile.

Logs (if relevant)

Logs

Replace this text with your logs, between the starting and ending triple backticks

[rarkins]

Code:

renovate/lib/modules/manager/dockerfile/extract.ts

Lines 314 to 333 in 96f760a

	const argRegex = regEx(
	'^[ \\t]*ARG(?:' +
	escapeChar +
	'[ \\t]*\\r?\\n| |\\t|#.*?\\r?\\n)+(?<name>\\w+)[ =](?<value>\\S*)',
	'im',
	);
	const argMatch = argRegex.exec(instruction);
	if (argMatch?.groups?.name) {
	argsLines[argMatch.groups.name] = [lineNumberInstrStart, lineNumber];
	let argMatchValue = argMatch.groups?.value;
	if (
	argMatchValue.charAt(0) === '"' &&
	argMatchValue.charAt(argMatchValue.length - 1) === '"'
	) {
	argMatchValue = argMatchValue.slice(1, -1);
	}
	args[argMatch.groups.name] = argMatchValue || '';
	}

Example test:

renovate/lib/modules/manager/dockerfile/extract.spec.ts

Lines 764 to 782 in 96f760a

	it('handles FROM with version in ARG value', () => {
	const res = extractPackageFile(
	'ARG\tVARIANT="1.60.0-bullseye" \nFROM\trust:${VARIANT}\n',
	'',
	{},
	)?.deps;
	expect(res).toEqual([
	{
	autoReplaceStringTemplate:
	'ARG\tVARIANT="{{#if newValue}}{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}" \n',
	currentDigest: undefined,
	currentValue: '1.60.0-bullseye',
	datasource: 'docker',
	depName: 'rust',
	depType: 'final',
	replaceString: 'ARG\tVARIANT="1.60.0-bullseye" \n',
	},
	]);
	});

Docs: https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/dockerfile/readme.md

[wwuck]

Thanks. I can't see anything relevant on that docs link but the regex reference in extract.ts should be enough for testing my configuration.

[rarkins]

Sorry, I meant that's where the docs should be added