Method "getHttpUrl" return wrong url for urls with ssh protocol with port

[websi]

What would you like help with?

I think I found a bug

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

GitLab

Please tell us more about your question or problem

In our setup we have private composer repositories an url with protocol ssh and define an non default port.

Example: ssh://[email protected]:22222/typo3-extensions/poll-pro.git

The method getHttpUrl within renovate/lib/util/git/url.ts changed this to https://gitlab.example.com:22222/typo3-extensions/poll-pro.git.
The port 22222 is wrong for https.

Source code:

renovate/lib/util/git/url.ts

Lines 14 to 16 in 376a2a5

	const protocol = regEx(/^https?$/).exec(parsedUrl.protocol)
	? parsedUrl.protocol
	: 'https';

In my local test the following line fixed the problem:

    const protocol = (0, regex_1.regEx)(/^https?$/).exec(parsedUrl.protocol)
        ? parsedUrl.protocol
        : 'https';
    parsedUrl.user = '';
    parsedUrl.token = token ?? '';
+   parsedUrl.port = '';

This is the very simple solution. Maybe the port can be configured via host rule.

Logs (if relevant)

Logs

Replace this text with your logs, between the starting and ending triple backticks

[rarkins]

It maybe makes sense to always strip the port from the transformed https url if the original was ssh? We know it won't be the same, so we may as well strip it?

[websi]

Yes the port is always not correct.

You also should think about to ignore the ssh to http tranformation at

renovate/lib/modules/datasource/git-refs/base.ts

Lines 45 to 47 in 376a2a5

	const lsRemote = await git.listRemote([
	getRemoteUrlWithToken(packageName, this.id),
	]);

Because you also generate git config to rewrite ssh to https via the git feature "url.insteadOf" .
This is never used, because the url is rewritten in method "getRemoteUrlWithToken".

For us the "url.insteadOf" feature is the prefered one, because we can inject our own configuration via the runner environment.

---

I think i found an second issue. Within

renovate/lib/util/git/auth.ts

Line 157 in 376a2a5

export function getGitEnvironmentVariables(

the configuration "customEnvVariables" is ignored. The method is called at

renovate/lib/modules/datasource/git-refs/base.ts

Line 33 in 376a2a5

const gitSubmoduleAuthEnvironmentVariables = getGitEnvironmentVariables([

[rarkins]

#28722

[websi]

The new version fixed our problem. Thank you.