Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add support for Xcelium #619 #620

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shareefj
Copy link

@shareefj shareefj commented May 21, 2024

This commit adds support for compiling the VerilatorIntegrationLibrary using Cadence Xcelium.

Related issue

#619

Description

Fixes a number of syntax issues in the VerilatorIntegrationLibrary SV sources files. See accompanying description in bug ticket.

Note that I don't have Questa to verify that there has been no regression.

Usage example

These fixes will enable the renode-dpi-examples repo to be updated with support for Xcelium. I'll release a secondary PR on that repo once done.

@shareefj shareefj force-pushed the feature/add_support_for_xcelium branch from a848408 to be206af Compare May 22, 2024 07:46
@PiotrZierhoffer
Copy link
Member

Hi @shareefj , thanks for the PR.

It's very interesting. We can double check it with Questa. I assume that you circumvent Hierarchical name ('bus.AddressWidth') not allowed within a constant expression by relaxing the rules on the Xcelium side?

@shareefj
Copy link
Author

shareefj commented May 22, 2024

Hi Piotr,

I did try relaxing the rules but it didn't work. I was just updating the associated ticket with a summary of where I'm at but this isn't ready to go yet. I can't run the tests due to what I think is an issue with the TCPClient code. More in the ticket shortly...

But for now, can you see if you can test Questa by setting the XCELIUM `define in the latest push. It seems Verilator can't handle that syntax so I'll raise a bug on them.

@shareefj
Copy link
Author

shareefj commented Jul 4, 2024

@PiotrZierhoffer This is ready to go. See accompanying issue and PR in renode-dpi-examples.

@shareefj shareefj force-pushed the feature/add_support_for_xcelium branch from 8fc052f to 6ceca15 Compare July 10, 2024 19:49
@shareefj
Copy link
Author

shareefj commented Aug 5, 2024

@PiotrZierhoffer Is this something that you think you'd like to merge or should I close this and just use my own fork?

@shareefj shareefj force-pushed the feature/add_support_for_xcelium branch from 6ceca15 to 7cbfcea Compare August 5, 2024 13:04
This commit adds support for compiling the VerilatorIntegrationLibrary
using Cadence Xcelium.
@shareefj shareefj force-pushed the feature/add_support_for_xcelium branch from 7cbfcea to 9f5f2f4 Compare September 18, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants