-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if message length exceeds 4096 bytes, it won't get processed correctly #46
Comments
Thanks - do you have a pull-request for this? |
No, sorry, I know almost nothing about github and don't know how to do that. If you want to point me to some steps I can learn without spending much time I'd be happy to try. Or I could send a diff or the updated EventSource.js file |
You can just go to https://github.com/remy/polyfills/blob/master/EventSource.js , click the pencil icon "Fork this project and edit the file". You can then save changes in your own fork, and GitHub should then prompt you to create a pull-request. Mention #46 in the commit-comment and pull request and it will automatically link here. Thanks. |
ok will do |
See remy#46. Update to properly and efficiently handle messages over 4096 bytes in size.
Here is a fix. It also performs better. Basically, it effectively does not increment the cache unless that data was actually processed into a MessageEvent.
cache
variable withchars_processed
cache = ''
line withchars_processed = 0
The text was updated successfully, but these errors were encountered: