-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOMTokenList contains implementation seems wrong #36
Comments
Apparently this was previous the way it worked before removing it after having problems with IE8's fireEvent: 898b546 |
Well I still think the current implementation is wrong. If I have an element with the class |
@sandersky commented on 26 aug. 2014 21:09 CEST:
Seems a valid bug, you're right. Wish above commit had a bug report attached to it; searching the Internet didn't find any similar issues with Edit: |
For me I only care about IE9 and above since IE8 is no longer supported by Microsoft (since April when they stopped XP support). With this being said I opted for the |
I believe your
contains
method forDOMTokenList
inclassList.js
is incorrect. It is checking the Element'sclassName
instead of the array of classes. In the event you check if aDOMTokenList
contains a string which is a substring of a class, it would return true when I believe it should return false. Instead it should be something like:The text was updated successfully, but these errors were encountered: