Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images from Gitter to Matrix #11

Open
remram44 opened this issue Dec 13, 2016 · 3 comments
Open

Images from Gitter to Matrix #11

remram44 opened this issue Dec 13, 2016 · 3 comments

Comments

@remram44
Copy link
Owner

Markdown issue, follows on #7

Gitter allows the ![alt](http://image.png) syntax to insert images in messages. Even though I correctly render to <img> in HTML, Riot strips it, only rendering attachments and previews.

I don't know how to fix this. There is just no way to get Riot to render embedded images.

@remram44
Copy link
Owner Author

7d41034 renders images as a link. The problem is when the original image is inside a link (Gitter generates [![alt](thumb_url)](fullsize_url)), then clicking will bring you to the image and not the link.

@remram44
Copy link
Owner Author

Emoji gets turned into images by pymdown. I added a workaround to ignore those, but really they should be unicode.

Filed facelessuser/pymdown-extensions#19

@remram44
Copy link
Owner Author

82afa9d fixes emoji rendering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant