Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition and promises #2098

Closed
benbonnet opened this issue Sep 27, 2015 · 5 comments
Closed

Transition and promises #2098

benbonnet opened this issue Sep 27, 2015 · 5 comments

Comments

@benbonnet
Copy link

Well, the point here will be based on the use of react-resolver; but maybe this problem could affect a larger audience. What react resolver does, is that it wait for the data before rendering. Forget bout transitioning components then when using react-router.

I've looked into many issues here that could relate, but I can't get a real understanding of the state of this problem. Can react-router wait for the component to render and still manage a regular css transition ?

@mjackson
Copy link
Member

I'm sorry. I don't understand your question.

@benbonnet
Copy link
Author

Hups, sorry for that.
I mean : if the next router renders with a slight delay (if it waits for a promise before rendering), no transition. React-router does not wait, replaces the current component with the next one, right away.

I guess #2101 explains it better ("This is simple if you don't care about transitioning")

@apapirovski
Copy link

@bbnnt you could just adapt my middleware component — that you referenced — for your use. It would enable you to use ReactCSSTransitionGroup. Or you can use react-resolver, although it seems somewhat incompatible with Flux architecture.

There is no built-in way — that I can see — of doing this.

@knowbody
Copy link
Contributor

knowbody commented Oct 6, 2015

is this still an issue @bbnnt ? if yes than I'll reopen

@knowbody knowbody closed this as completed Oct 6, 2015
@benbonnet
Copy link
Author

@knowbody here (https://github.com/rackt/react-router-mega-demo/blob/master/app/handlers/Root.js#L61) it handles the "component" load
I still have an issue, but I guess I need to have a closer look at all this

@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants