Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propertize reverses the order of elements #1521

Open
ngortheone opened this issue Jun 12, 2019 · 5 comments
Open

propertize reverses the order of elements #1521

ngortheone opened this issue Jun 12, 2019 · 5 comments

Comments

@ngortheone
Copy link
Contributor

ngortheone commented Jun 12, 2019

Something that I discovered during investigation on #1513

This is fixed in emacs 27.0.50

ELISP> (propertize " " "1" "2" "3" "4" "5" "6")
#(" " 0 1
  ("1" "2" "3" "4" "5" "6"))

But both in Emacs 26.2 and in Remacs still have it

ELISP > (propertize " " "1" "2" "3" "4" "5" "6")
#(" " 0 1
  ("5" "6" "3" "4" "1" "2"))

Since propertize was ported we can't rely on C patch to fix

@shaleh
Copy link
Collaborator

shaleh commented Jun 12, 2019

But will us fixing it now break the Lisp code we have from 26? That is the key question.

I am working on bring all of the removed C back into the project so we can track these kinds of changes more easily.

@ngortheone
Copy link
Contributor Author

ngortheone commented Jun 12, 2019

The confusion is that remacs reports version 27.0.50, while mostly behaves like 26.2.
As I was investigating #1513
I have loaded melpa packages from 26 branch and I have different behavior. Icons are resizing but the images are all blank now...(only icon frame is visible) :(

This is a source of problems with spacemacs. It uses version number to determine where from packages should be downloaded

@shaleh
Copy link
Collaborator

shaleh commented Jun 12, 2019

Yes the 27.0.50 is a mistake we need to fix. Please open a ticket so we can revert the files to the proper versions.

@shanavas786
Copy link
Collaborator

Yes the 27.0.50 is a mistake we need to fix.

@shaleh I don't really think so. Remacs is based on emacs' master branch (current merge base is 64c85e68) and it has version 27.0.50

@shaleh
Copy link
Collaborator

shaleh commented Jun 13, 2019

@shanavas786 it was started from master. Like 3 years ago. It is not 27.x compatible. All of the 27.x in remacs is in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants