Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for failing ghrelease activity due to changes to device flow auth #259

Open
gforsyth opened this issue Jul 8, 2022 · 14 comments

Comments

@gforsyth
Copy link

gforsyth commented Jul 8, 2022

GitHub now returns 400s if you try to login via an oauth app for device flow if the oauth app in question has not checked the "Enable device flow" option.

I don't know who currently owns the rever oauth app that is used, but if you are blocked by this, you can work around it by creating your own.

Go to https://github.com/settings/applications/new
Give it a name, the callback url can be anything (like http://localhost) since it won't be used.
Then check "Enable Device Flow" and save the app.

Copy the "Client ID" of your new app and paste that into rever/github.xsh around line 44 and replace the listed client id for REVER_CLIENT_ID.

Then the login flow should work to authorize the device

@hadim
Copy link
Contributor

hadim commented Jul 23, 2022

@scopatz @CJ-Wright could someone enable that feature?

@hadim
Copy link
Contributor

hadim commented Oct 12, 2022

@CJ-Wright @saraedum is that something one of you could do?

Following the above instructions works just fine for me but it requires modifying the REVER_CLIENT_ID within the source code of rever (which is not super convenient).

I think creating a GH app for the regro GH org and updating the rever client id is all we need here.

@hadim
Copy link
Contributor

hadim commented Oct 12, 2022

Also simply updating the current GH app by checking "Enable Device Flow" should be enough.

@sbillinge
Copy link
Collaborator

Let me look into this today.

@GbotemiB
Copy link

I had this same issue, it hasnt been fixed yet

@hadim
Copy link
Contributor

hadim commented Nov 28, 2022

@sbillinge have you been able to fix that?

@saraedum
Copy link
Collaborator

I don't think I have the permissions to change that application @CJ-Wright

@saraedum
Copy link
Collaborator

The application seems to be owned by @regro so we would need help (or permissions) from one of @xhochy, @ocefpaf, @isuruf, @CJ-Wright, @marcelotrevisani probably.

@xhochy
Copy link
Member

xhochy commented Jan 21, 2023

I don't have enough rights here

@ocefpaf
Copy link
Member

ocefpaf commented Jan 25, 2023

I don't have enough rights here

Same.

@CJ-Wright
Copy link
Member

CJ-Wright commented Jan 27, 2023

Also simply updating the current GH app by checking "Enable Device Flow" should be enough.

Which GH app is this exactly?

Is this the regro-bot app?

@beckermr I think you may be the last person to work on that app.

I am making this comment solely in my personal capacity and am not conveying any rights to any intellectual property of any third parties.

@beckermr
Copy link

Wasn't me.

@CJ-Wright
Copy link
Member

@wolfv @mariusvniekerk are you aware of the regro-bot? Is that being used for CF things or is this a rever thing?

(Sorry for the additional delay, just trying to do all due diligence before making changes to a potentially communal resource)

I am making this comment solely in my personal capacity and am not conveying any rights to any intellectual property of any third parties.

@CJ-Wright
Copy link
Member

Now I found the right app. I think you should be good to go. Email is the best way to reach out to me these days.

Cheers,
CJ

I am making this comment solely in my personal capacity and am not conveying any rights to any intellectual property of any third parties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants