Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookiecut - Python 3.11, 3.12, 3.13 priority tasks and communication channel #1182

Open
bobleesj opened this issue Nov 6, 2024 · 12 comments

Comments

@bobleesj
Copy link
Contributor

bobleesj commented Nov 6, 2024

(To be closed after we are done with cookiecuting)

  • always make a PR into the cookie branch
@bobleesj
Copy link
Contributor Author

bobleesj commented Nov 6, 2024

Priority

  1. pre-commit setup
  1. pip install -e . && pytest runs
  1. Proper GitHub CI setup
  1. Python 3.11 support

  1. Python 3.12 support
  1. Python 3.13 support
  1. Pytest, docs, tutorials, warnings
  1. Conda-forge

Goal: make a good looking package satisfying our Release checklist

@tinatn29 since I've created lots of issues, I wanted to organize them a bit - we can use this issue here to communicate any tasks that are of interest to all maintainers/reviewers.

@bobleesj bobleesj changed the title Quick note for all cookiecutting contributors Quick note and priority tasks for all cookiecutting contributors Nov 6, 2024
@bobleesj
Copy link
Contributor Author

(A quick note to maintainers) recut this package before we are about to make a release checklist

@tinatn29
Copy link
Contributor

created #1200 and #1201 to fix pytest skipped and warnings

@bobleesj
Copy link
Contributor Author

@tinatn29 Since we have Python 3.11 CI configured here #1203, we could address all of the issues under Python 3.11 support (remove warnings/skipped tests) above and then update our CI to 3.12, then 3.13, resolving issues systematically..

@bobleesj bobleesj changed the title Quick note and priority tasks for all cookiecutting contributors Cookiecut - Python 3.11, 3.12, 3.13 priority tasks and communication channel Nov 27, 2024
@sbillinge
Copy link
Contributor

@bobleesj @tinatn29 is most of the cookiecutting done, and now it is remediating all the technical debt? If so, I am inclined to merge cookie into main as all the tests are currently passing on CI. If all the large moving around of files is done and CI is running we can do future updates into main. OK to merge cookie into main?

@bobleesj
Copy link
Contributor Author

@sbillinge We still need to move test files outside of src. This, I will look into it. Then, we can probably merge cookie to main.

@bobleesj
Copy link
Contributor Author

@sbillinge I double checked - tests is moved out of src already. Thanks to @tinatn29

Yes, looks good to merge to main.

@bobleesj
Copy link
Contributor Author

bobleesj commented Dec 12, 2024

One last thing - @sbillinge could you setup pre-commit at the repository level? It should all pass.

Screenshot 2024-12-11 at 8 59 43 PM

Ref: #1181

@sbillinge
Copy link
Contributor

haha, getting to green...
image

pre-commit working on the repo....codecov working on the repo (everything red before). The tests on pr (push) would turn red if I raran it as it runs the same thing as tests on pr (pull request). I guess there is no news, but I think there may be a news that was merged direclty to main before we went to the cookie branch. I will merge like this since tests are passing and then check.

@bobleesj
Copy link
Contributor Author

@sbillinge @tinatn29 yes, great and steady progress.. it will be SO much easier to build on this repo moving forward!

@tinatn29
Copy link
Contributor

@sbillinge @bobleesj How do I fix skipped tests #1200? Do I need to do this before proceeding with the API documentation step (is there an issue for this already?) and adding news #1214?

@sbillinge
Copy link
Contributor

leave the skips for now. Many of them are only skipped on some platforms. I think they are not a tip priority. We can return to them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants