Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF-2824] rx.recharts.polar_radius_axis is missing the domain prop #3283

Open
masenf opened this issue May 13, 2024 · 2 comments
Open

[REF-2824] rx.recharts.polar_radius_axis is missing the domain prop #3283

masenf opened this issue May 13, 2024 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@masenf
Copy link
Collaborator

masenf commented May 13, 2024

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  • Code/Link to Repo:

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Specifics (please complete the following information):

  • Python Version:
  • Reflex Version:
  • OS:
  • Browser (Optional):

Additional context
Add any other context about the problem here.

REF-2824

@masenf masenf changed the title rx.recharts.polar_radius_axis is missing the domain prop [REF-2824] rx.recharts.polar_radius_axis is missing the domain prop May 13, 2024
@masenf masenf added good first issue Good for newcomers help wanted Extra attention is needed labels May 14, 2024
@TG199
Copy link
Contributor

TG199 commented May 20, 2024

Hi @masenf I checked the link above that leads to the Discord channel. By my understanding, you've provided the solution of this issue there. The only thing missing to get this resolved is a PR. So I just need to add the following line custom_attrs=dict(domain=rx.Var.create([0, 250])) to the file reflex./components/recharts/polar.py in the component PolarRadiusAxis(Recharts):

@masenf
Copy link
Collaborator Author

masenf commented May 20, 2024

@TG199 All that's needed here is a PR that adds domain as a list[int] prop to the PolarRadiusAxis component.

The custom_attrs thing is a hackaround for forcing an attribute to be rendered into the compiled output, even when it's not declared as a prop for the component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants