Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF-2811] rx.section default size 3 is "too big" #3274

Open
masenf opened this issue May 10, 2024 · 2 comments
Open

[REF-2811] rx.section default size 3 is "too big" #3274

masenf opened this issue May 10, 2024 · 2 comments
Assignees
Labels
enhancement Anything you want improved good first issue Good for newcomers

Comments

@masenf
Copy link
Collaborator

masenf commented May 10, 2024

Describe the bug
The nice thing about the rx.section (aside from being semantic) is that it adds healthy margins between page content areas... however the default size="3" is too much space and does not really look good.

I propose changing the default to size="2" so that downstream users don't need to change the not-great-looking default.

Expected behavior
The default should "look good"

Screenshots
Here is the default section spacing

image

And with size="2"

image

Specifics (please complete the following information):

  • Python Version: 3.11.8
  • Reflex Version: 0.5.0a1

From SyncLinear.com | REF-2811

@masenf masenf added enhancement Anything you want improved good first issue Good for newcomers labels May 10, 2024
@masenf masenf changed the title rx.section default size 3 is "too big" [REF-2811] rx.section default size 3 is "too big" May 10, 2024
@kusumdesai
Copy link

Hey @masenf !!
Please assign this to me under GSSoC'24..

@masenf
Copy link
Collaborator Author

masenf commented May 11, 2024

@kusumdesai check out how we override the size for the radix Container component for an example of how this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Anything you want improved good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants