rector does nothing.

[N6REJ]

I'm trying to upgrade from php 5.6.40 to php 8.2.26
I followed these instructions since my code is currently built for php 5.6.40
https://getrector.com/documentation/how-to-run-on-php-53 and what I get is just a blank return.

From what I understand its supposed to show a progress bar and take only a few minutes. I've had it running for hours with nothing indicating its doing anything.
I also noticed it left out my bins folder.
And I'm not sure that it will process all the .php files in my classes folder, which it needs to do.
What am I doing wrong?
i'm using php 8.3.11 for my active php

and composer is 2.7.9

[samsonasik]

composer require without composer init cause composer.json not created, could you try initialization:

composer init

to ensure composer.json exists in the first place on rector-standalone directory, then re-run composer require rector/rector --dev

composer init
composer require rector/rector --dev

[N6REJ]

I did that and nothing changed.

[samsonasik]

I tried and it seems working ok

could you try single file only to target file, eg:

../rector-standalone/vendor/bin/rector process actions/Foo.php  --dry-run

if that works, please narrow down to locate what file that cause it

Read this post: https://tomasvotruba.com/blog/2021/02/01/effective-debug-tricks-narrow-scoping/

[N6REJ]

still didn't work. idk wth I'm doing wrong.

[samsonasik]

It seems you're using windows, could you try to use command prompt (cmd) or bash for Windows ? see readme for it

https://github.com/rectorphp/rector?tab=readme-ov-file#known-drawbacks

If still not works, could you try disable parallel? Add:

->withoutParallel();

in the config

[N6REJ]

I was using the jetbrains IDEA ide terminal. I just tried with command prompt with same result.

[samsonasik]

Not sure, could you share simple repository with minimal files to let us try? We don't have windows env locally, but let see if we can reproduce it in other os

[N6REJ]

I appreciate all your help. The only folder we need to be concerned with is /core/classes and its children.
https://github.com/Bearsampp/sandbox/tree/rector/core/classes

[samsonasik]

I tried that, it seems working ok:

➜  classes git:(main) ✗ ../rector-standalone/vendor/bin/rector process --dry-run |more
 44/44 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
44 files with changes
=====================

1) tpls/app/class.tpl.app.nodejs.php:38

    ---------- begin diff ----------
@@ @@
         return TplApp::getMenuEnable(
             $bearsamppLang->getValue(Lang::NODEJS),
             self::MENU,
-            get_called_class(),
+            static::class,
             $bearsamppBins->getNodejs()->isEnable()
         );
     }
@@ @@
         // Enable
         $tplEnable = TplApp::getActionMulti(
             self::ACTION_ENABLE,
-            array($isEnabled ? Config::DISABLED : Config::ENABLED),
-            array($bearsamppLang->getValue(Lang::MENU_ENABLE), $isEnabled ? TplAestan::GLYPH_CHECK : ''),
+            [$isEnabled ? Config::DISABLED : Config::ENABLED],
+            [$bearsamppLang->getValue(Lang::MENU_ENABLE), $isEnabled ? TplAestan::GLYPH_CHECK : ''],
             false,
-            get_called_class()
+            static::class
         );

is that any different if you run rector on github action or same directory inside classes itself?

[N6REJ]

I don't understand what you mean. How can I do that. I'll happily change ANYTHING. Also how do I make sure it does the file in classes as well as all sub directories

[samsonasik]

You may can setup github action for windows, with set windows-latest on os matrix, create steps in the config so it can run rector on github, for example:

https://github.com/rectorphp/rector-src/blob/main/.github/workflows/tests.yaml#L20

You may can read documentation for github action quick start https://docs.github.com/en/actions/writing-workflows/quickstart

[staabm]

I think your php is halting because you have something like "break on first statement" enabled in phpstorm.

Try disabling xdebug in your php CLI and run again