Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it necessary to have dplyr as a dependency? #83

Open
zkamvar opened this issue Jul 27, 2018 · 2 comments
Open

Is it necessary to have dplyr as a dependency? #83

zkamvar opened this issue Jul 27, 2018 · 2 comments
Assignees

Comments

@zkamvar
Copy link
Member

zkamvar commented Jul 27, 2018

I did a search for dplyr in this repo and found this: https://github.com/reconhub/epicontacts/search?q=dplyr&type=Code

Basically, dplyr is only used for joins right now and I'm wondering if it may be better to just switch over to base::merge() to lighten up the dependencies.

@vpnagraj vpnagraj self-assigned this Sep 7, 2018
@vpnagraj
Copy link
Collaborator

vpnagraj commented Sep 7, 2018

@zkamvar great point, i'd prefer to lose the dplyr dependency if possible ... i'm working on replacing the joins and printing with base functions

@zkamvar
Copy link
Member Author

zkamvar commented Feb 14, 2019

FWIW, I think the printing is much better keeping the tibble format. I think it's worth keeping tibble around when we drop dplyr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants