Convert to FCs/Hooks

[amcdnl]

Requirement

• Convert components to FCs
• Convert utils to hooks

Tasks

FCs

• Bar Chart
• Area Chart
• Heatmap
• Hive Plot
• Sankey
• Line Chart
• Linear Gauge
• Pie Chart
• Radial Area
• Radial Line
• Radial Bar Chart
• Radial Scatter Plot
• Scatter Plot
• Sparklines
• Axis
• Gridlines
• Brush
• Legends
• Tooltip
• Masks

Hooks

• Zoom
• Pan
• Move
• ZoomPan
• ChartZoomPan
• ChartContainer

Known Issues

Parent Reading Child Props

Parent components who rely on nested properties for processing ( such as gridline direction ) will not work correctly in the current implementation. Example:

  renderSeries(
    yAxisGrid,
    xAxisGrid,
    element: GridElement,
    type: 'line' | 'stripe'
  ) {
    const { xScale, yScale } = this.props;

    return (
      <Fragment>
        {this.shouldRenderY(element.props.direction) &&
          this.renderGroup(element, yAxisGrid, yScale, 'y', type)}
        {this.shouldRenderX(element.props.direction) &&
          this.renderGroup(element, xAxisGrid, xScale, 'x', type)}
      </Fragment>
    );
  }

In this scenario, element.props.direction will be undefined since its not longer a component class.

This can be fixed by setting those defaults on the parent though. See this commit for more info: e156d00

Pan Zoom

I'm considering using the gestures library I used in reaflow for the pan / zoom operations.

[ynahmany]

@amcdnl you can update: areachart, heatmap and hiveplot are done.

[amcdnl]

Done 🎉

[KukR1]

@amcdnl are the tasks up to date? because I want to help on here..

[amcdnl]

@KukR1 - Thats awesome; any contribution would be welcome! Sadly No they aren't - but just look for anything called Component or PureComponent in the source code and give it a shot.

[csdiehl]

@amcdnl I'm a data visualization developer who does a lot of work with React and D3, and am interested in contributing to this project. I can tackle some of these component conversions if there are still more to do - should I work on the functional_components branch or take out a new branch?