-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory Leak? #20
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey,
Im very new to Reason so was just looking through this codebase trying to learn real-world examples of how to do things and I came across this line:
https://github.com/reasonml-community/reason-react-hacker-news/blob/master/src/TopStoriesPage.re#L49
Im wondering if this is a memory leak because it doesnt get un-listened when the component unmounts?
It might explain this console error you get when running locally:
Im submitting this is an issue rather than doing a PR because im very new so no doubt im missing something here. Ill happily attempt a PR if this is indeed an issue.
The text was updated successfully, but these errors were encountered: