Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wf-list: nothing happens when clicking on REANA logo #374

Open
mdonadoni opened this issue Dec 13, 2023 · 2 comments
Open

wf-list: nothing happens when clicking on REANA logo #374

mdonadoni opened this issue Dec 13, 2023 · 2 comments
Projects

Comments

@mdonadoni
Copy link
Member

Clicking the REANA logo in the top-left part of the UI brings the user back to the workflow list page.

image

However, if the user is already on the workflow list page nothing happens, even if the workflow list is being filtered and/or if the selected page is not the first one. Instead, I would expect the page to be refreshed, any filtering to be removed and to be brought back to the first page of the workflow list.

@mdonadoni mdonadoni added this to Ready for work in 0.95.0 Mar 14, 2024
@Alputer Alputer moved this from Ready for work to In work in 0.95.0 May 30, 2024
@Alputer Alputer self-assigned this May 30, 2024
@Alputer
Copy link
Member

Alputer commented May 30, 2024

Currently, we use local state for search parameters and the page number on the WorkflowList page as shown below:

image

However, to refresh the page after clicking on the "reana" logo, the best approach is to switch this local state to a global state in Redux since we do not have access to this local state inside the header component. Global state in Redux is also bit tricky because we already have another "WORKFLOW_LIST_REFRESH" action in Redux, which is somewhat misleading in its purpose.

image

Therefore, I propose combining this task with refactoring the refreshing, pagination, and searching mechanism of the WorkflowList page.

@Alputer Alputer removed their assignment May 30, 2024
@Alputer Alputer moved this from In work to Ready for work in 0.95.0 May 30, 2024
@mdonadoni
Copy link
Member Author

See also: #398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
0.95.0
Ready for work
Development

No branches or pull requests

2 participants