Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

models: allow more than nine restarts #186

Closed
audrium opened this issue Nov 29, 2022 · 0 comments · Fixed by #205 · May be fixed by reanahub/reana-server#637 or reanahub/reana-commons#416
Closed

models: allow more than nine restarts #186

audrium opened this issue Nov 29, 2022 · 0 comments · Fixed by #205 · May be fixed by reanahub/reana-server#637 or reanahub/reana-commons#416
Assignees
@mdonadoni @giuseppe-steduto

Comments

@audrium
Copy link
Member

audrium commented Nov 29, 2022

After implementing a fix for models: incorrect run number assignment after many restarts we now have a limit to permit at most nine restarts of a workflow:

$ reana-client restart -w workflow
==> ERROR: Cannot start workflow workflow:
Cannot restart a workflow more than 9 times

This is due the way we currently store run_number value in the DB as a single float field. We should implement a different way to store this value in the DB which would solve this issue. One possible solution would be to store each run number as two integers and update the rest of the codebase accordingly.
@audrium audrium mentioned this issue Nov 29, 2022
Closed
giuseppe-steduto added a commit to giuseppe-steduto/reana-db that referenced this issue Oct 2, 2023
@giuseppe-steduto
models: replace workflow.run_number with generation and restart number
1432ec4 
Change the workflow table to split the run_number into two integers: one
referring to the generation of the workflows, and the other one
referring to the restart number, thus removing the limit of 9 restarts.

Closes reanahub#186.
@giuseppe-steduto giuseppe-steduto mentioned this issue Oct 2, 2023
Merged
giuseppe-steduto added a commit to giuseppe-steduto/reana-db that referenced this issue Oct 11, 2023
@giuseppe-steduto
models: replace workflow.run_number with generation and restart number
ff651aa 
Change the workflow table to split the run_number into two integers: one
referring to the generation of the workflows, and the other one
referring to the restart number, thus removing the limit of 9 restarts.

Closes reanahub#186.
giuseppe-steduto added a commit to giuseppe-steduto/reana-db that referenced this issue Oct 11, 2023
@giuseppe-steduto
models: replace workflow.run_number with generation and restart number
5b544d4 
Change the workflow table to split the run_number into two integers: one
referring to the generation of the workflows, and the other one
referring to the restart number, thus removing the limit of 9 restarts.

Closes reanahub#186.
giuseppe-steduto added a commit to giuseppe-steduto/reana-db that referenced this issue Oct 11, 2023
@giuseppe-steduto
models: replace workflow.run_number with generation and restart number
ef5f9d4 
Change the workflow table to split the run_number into two integers: one
referring to the generation of the workflows, and the other one
referring to the restart number, thus removing the limit of 9 restarts.

Closes reanahub#186.
giuseppe-steduto added a commit to giuseppe-steduto/reana-db that referenced this issue Oct 11, 2023
@giuseppe-steduto
models: replace workflow.run_number with generation and restart number
5a14407 
Change the workflow table to split the run_number into two integers: one
referring to the generation of the workflows, and the other one
referring to the restart number, thus removing the limit of 9 restarts.

Closes reanahub#186.
giuseppe-steduto added a commit to giuseppe-steduto/reana-db that referenced this issue Oct 16, 2023
@giuseppe-steduto
models: replace workflow.run_number with major and minor run numbers
d6eeafe 
Change the workflow table to split the run_number into two integers: one
is the major run number (the number before the dot), and the other one
 is the minor run number (after the dot), which increases when
 restarting a workflow, thus removing the limit of 9 restarts.

Closes reanahub#186.
giuseppe-steduto added a commit to giuseppe-steduto/reana-db that referenced this issue Oct 16, 2023
@giuseppe-steduto
models: replace workflow.run_number with major and minor run numbers
79f8221 
Change the workflow table to split the run_number into two integers: one
is the major run number (the number before the dot), and the other one
is the minor run number (after the dot), which increases when
restarting a workflow, thus removing the limit of 9 restarts.

Closes reanahub#186.
giuseppe-steduto added a commit to giuseppe-steduto/reana-db that referenced this issue Oct 30, 2023
@giuseppe-steduto
models: replace workflow.run_number with major and minor run numbers
58fa915 
Change the workflow table to split the run_number into two integers: one
is the major run number (the number before the dot), and the other one
is the minor run number (after the dot), which increases when
restarting a workflow, thus removing the limit of 9 restarts.

Closes reanahub#186.
giuseppe-steduto added a commit to giuseppe-steduto/reana-db that referenced this issue Oct 30, 2023
@giuseppe-steduto
models: replace workflow.run_number with major and minor run numbers
850065f 
Change the workflow table to split the run_number into two integers: one
is the major run number (the number before the dot), and the other one
is the minor run number (after the dot), which increases when
restarting a workflow, thus removing the limit of 9 restarts.

Closes reanahub#186.
mdonadoni added a commit to mdonadoni/reana-server that referenced this issue Nov 1, 2023
@mdonadoni
openapi: add missing run_number field to start_workflow response
5eaaf38 
Closes reanahub/reana-db#186
@mdonadoni mdonadoni mentioned this issue Nov 1, 2023
Draft
mdonadoni added a commit to mdonadoni/reana-commons that referenced this issue Nov 1, 2023
@mdonadoni
openapi: add missing run_number field to start_workflow response
081e485 
Closes reanahub/reana-db#186
@mdonadoni mdonadoni mentioned this issue Nov 1, 2023
Draft
mdonadoni added a commit to mdonadoni/reana-commons that referenced this issue Nov 6, 2023
@mdonadoni
openapi: add missing run_number field to start_workflow response
650d1db 
Closes reanahub/reana-db#186
mdonadoni added a commit to mdonadoni/reana-server that referenced this issue Nov 6, 2023
@mdonadoni
openapi: add missing run_number field to start_workflow response
fae7c49 
Closes reanahub/reana-db#186
mdonadoni added a commit to mdonadoni/reana-commons that referenced this issue Nov 6, 2023
@mdonadoni
openapi: add missing run_number field to start_workflow response
b733031 
Closes reanahub/reana-db#186
@mdonadoni mdonadoni self-assigned this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdonadoni mdonadoni

@giuseppe-steduto giuseppe-steduto

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@audrium @mdonadoni @giuseppe-steduto