Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: SSHClient should not be a singleton #456

Open
mdonadoni opened this issue Jun 27, 2024 · 0 comments
Open

refactor: SSHClient should not be a singleton #456

mdonadoni opened this issue Jun 27, 2024 · 0 comments

Comments

@mdonadoni
Copy link
Member

After adding the Compute4PUNCH backend, the SSHClient is now used by two different backends. However, the client is implemented as a singleton, so it can't be used by the two backends at the same time. This means that workflows whose jobs run on multiple backends will not work if more than one of the chosen backends rely on SSH to dispatch jobs.

While this is not a big issue for now, as we do not expect to have instances that enable both Slurm@CERN and Compute4PUNCH, we should in any case refactor SSHClient to not be a singleton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant